You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements file associations for Graphite on both Linux and Windows platforms. On Linux, it updates the desktop entry and adds a MIME type definition. For Windows, it introduces a registry registration mechanism to associate .graphite and several image formats with the application. Feedback was provided regarding an inconsistency between the supported file extensions on Windows and the MIME types declared for Linux, suggesting an expansion of the Windows list for better platform parity.
The reason will be displayed to describe this comment to others. Learn more.
The list of supported extensions for Windows is inconsistent with the MIME types declared for Linux in desktop/assets/art.graphite.Graphite.desktop. To ensure feature parity across platforms, consider adding the missing supported file extensions.
The Linux desktop file includes support for GIF, BMP, TIFF, WebP, PNM (PPM, PGM, PBM), and ICO formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #4123
doing this on win feels horrible