Skip to content

Remove code for the deprecated and unused Curve type#4127

Merged
Keavon merged 2 commits intomasterfrom
deprecate-curve-type
May 7, 2026
Merged

Remove code for the deprecated and unused Curve type#4127
Keavon merged 2 commits intomasterfrom
deprecate-curve-type

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented May 7, 2026

No description provided.

@Keavon Keavon changed the title Deprecate the legacy, unused Curve type Remove code for the deprecated and unused Curve type May 7, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Curve widget and its associated functionality from the codebase, including its handling in the layout message handler, widget definitions, and node registry. The reviewer suggests deleting the commented-out code for CurveInput and curve_widget instead of leaving it in the source files to maintain cleanliness.

Comment thread editor/src/messages/layout/utility_types/widgets/input_widgets.rs
@Keavon Keavon merged commit dff8ac5 into master May 7, 2026
11 checks passed
@Keavon Keavon deleted the deprecate-curve-type branch May 7, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant