Archive low quality patterns - #426
Open
russelltrow wants to merge 1 commit into
Open
Conversation
#424 Archiving patterns that score 4 or less against the 11 core quality principles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archiving patterns that score 4 or less against the 11 core quality principles
#424
Across all five categories assessed (Requirements, Architecture, Design, Development, Operations — 65 patterns total), here are the ones that passed 4 or fewer of the 11 Core Quality Principles:
yelghali) repeats this exact template in evaluate-whether-to-use-TLS-termination — worth flagging to that contributor specifically.Common thread: all seven are missing Cost Impact; five of seven fail on testable Assumptions (vague hedge, tautology, or literal "None").
Six of the seven are in Architecture — that category's
technology-selectionfolder in particular (3 of its 5 patterns land here) is the weakest spot found across the whole review. Operations and Design had none at this threshold, despite Operations carrying the worst duplication problem — its individual patterns were generally thin/incomplete rather than fundamentally broken on this many fronts at once.Common thread across all seven: every one of them fails Principle 5 (Complete Required Sections) and Principle 10 (Trade-off Visibility) — all seven are missing Cost Impact — plus most also fail Principle 8 (Testable Assumptions). Two of them (
energy-efficent-framework,energy-efficent-models) are the literal "None"/"None" stub patterns flagged earlier.use-energy-efficient-hardwareis the single weakest pattern found in this entire five-category review.