feat: 好友管理 - #6317
Conversation
枯荣有数，屡变星霜，天行有常，本不为古今更易、人事存亡。`
|
@codex review |
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65f923fc7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aa1484bd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: caf2ec8dd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .whenComplete(Schedulers.javafx(), (result, exception) -> { | ||
| setLoading(false); |
There was a problem hiding this comment.
When the user clicks the toolbar refresh while the constructor-triggered or another refresh is still running, the toolbar remains enabled and both tasks execute concurrently. The first callback to finish clears loading even if another request is active, and a slower older callback can subsequently overwrite the newer list or replace it with a failure overlay. Disable/cancel overlapping refreshes or ignore callbacks from superseded requests.
Useful? React with 👍 / 👎.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39fddfd238
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Task.supplyAsync(() -> control.updateFriend(null, item.profileId(), updateType)).whenComplete(Schedulers.javafx(), (result, exception) -> { | ||
| if (exception != null) { | ||
| LOG.warning("Failed to update friend", exception); | ||
| fireEvent(new DialogCloseEvent()); |
There was a problem hiding this comment.
When an accept, reject, revoke, or remove request completes, this event is fired on the background FriendListPage, while DialogUtils.show installs its close handler on the MessageDialogPane passed to Controllers.dialog. Because the page is not a descendant of that dialog, the event never reaches the handler: successful operations leave the confirmation modal stuck on its spinner, and failures push the error dialog over the same stuck confirmation. Fire the event from stackPane or the dialog content instead.
Useful? React with 👍 / 👎.
2 participants
resolves #6157
resolves #6114