Skip to content

[Feature] 支持 CoreMod 读取 - #6625

Open
ToobLac wants to merge 31 commits into
HMCL-dev:mainfrom
ToobLac:coremod
Open

[Feature] 支持 CoreMod 读取#6625
ToobLac wants to merge 31 commits into
HMCL-dev:mainfrom
ToobLac:coremod

Conversation

@ToobLac

@ToobLac ToobLac commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Closes #6623 Fixes #5555

添加了对 forge 模组形式的 liteloader 的支持
顺便修复了 1.13.2 Forge REI 元数据加载不出来的问题

@github-actions github-actions Bot added the 100+ label Aug 7, 2026
@ToobLac
ToobLac marked this pull request as ready for review August 7, 2026 11:05
@ToobLac

ToobLac commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

我们需要尽可能多的 coremod 来进行测试

@ToobLac
ToobLac marked this pull request as draft August 7, 2026 14:51
@ToobLac
ToobLac marked this pull request as ready for review August 9, 2026 13:57
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/meta/CoreMod.java Outdated
@ToobLac ToobLac closed this Aug 14, 2026
@ToobLac ToobLac reopened this Aug 14, 2026
@ToobLac
ToobLac marked this pull request as draft August 14, 2026 04:30
@ToobLac
ToobLac marked this pull request as ready for review August 18, 2026 14:04
@Glavo

Glavo commented Aug 19, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49fce0ba08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/meta/CoreMods.java Outdated
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/meta/ForgeNewModMetadata.java Outdated
@ToobLac
ToobLac marked this pull request as draft August 19, 2026 14:36
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java
@ToobLac
ToobLac marked this pull request as ready for review August 27, 2026 15:06
ToobLac and others added 3 commits September 4, 2026 22:50
@Glavo

Glavo commented Sep 9, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T12:45:27.291663Z 55c2cff Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55c2cff558

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5.6 Sol 生成


已将具体审查建议标注在对应代码行。

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java Outdated
@ToobLac

ToobLac commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

这个 Actions 是何意味啊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 支持多加载器模组 [Bug] I18nUpdateMod会被视为Fabric模组而提示与(Neo)Forge加载器不匹配

4 participants