[Feature] 显示模组/依赖是否已安装 by ToobLac · Pull Request #6723 · HMCL-dev/HMCL

ToobLac · 2026-08-22T08:40:41Z

目前自动补全依赖还是难以可靠实现，但检查是否已经安装还是可以做到的

ToobLac · 2026-08-24T08:13:31Z

想到一个更好的实现方法

Glavo · 2026-08-26T13:43:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b649c26f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Minecraft269 · 2026-08-27T08:54:42Z

对了 CC @ToobLac NFE的 #6230 好像有看依赖关系的功能你看看?

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java

Glavo · 2026-09-07T13:59:58Z

@codex review

chatgpt-codex-connector · 2026-09-07T14:00:13Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T12:44:47.768701Z	`dbc85ea`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b131a74f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Glavo

本审查建议由 GPT-5.6 Sol 生成

已将具体审查建议标注在对应代码行。

Glavo

本审查建议由 GPT-5.6 Sol 生成

已将具体审查建议标注在对应代码行。

Glavo · 2026-09-09T12:38:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbc85ea2a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-09T12:44:45Z

+            ).whenComplete(Schedulers.io(), exception -> {
+                if (exception == null && instance != null) {
+                    var manager = instance.getManagerForType(type);
+                    if (manager != null) manager.invalidate();


Refresh the installed badge after a successful download

When an addon is downloaded from its detail page, that page remains open and its installed property is only assigned by the initial loadAddonVersions() call. Even with this new manager invalidation, a successful download never rechecks or updates that property, so the page continues to show the addon as not installed until the user leaves and reopens it; notify the detail page of completion or trigger a new installed check after success.

Useful? React with 👍 / 👎.

我觉得这是小问题

# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/CurseForgeRemoteAddonRepository.java

ToobLac added 2 commits August 22, 2026 11:22

preparation

7e633f1

impl

daaff93

github-actions Bot added the 100+ label Aug 22, 2026

update

93f5ed7

ToobLac marked this pull request as draft August 22, 2026 10:19

avoid fetching version list twice

5758cc9

github-actions Bot added 500+ and removed 100+ labels Aug 22, 2026

ToobLac changed the title ~~[Feature] 显示依赖是否已安装~~ [Feature] 显示模组/依赖是否已安装 Aug 22, 2026

ToobLac marked this pull request as ready for review August 22, 2026 14:00

ToobLac marked this pull request as draft August 24, 2026 08:13

re-impl

b649c26

github-actions Bot added 100+ and removed 500+ labels Aug 24, 2026

ToobLac marked this pull request as ready for review August 24, 2026 15:16

chatgpt-codex-connector Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/RemoteAddon.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonManager.java Outdated

ToobLac marked this pull request as draft August 27, 2026 04:21

update

b3832b4

ToobLac marked this pull request as ready for review August 27, 2026 08:35

github-actions Bot added 500+ and removed 100+ labels Aug 27, 2026

ToobLac mentioned this pull request Aug 27, 2026

[Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测及级联处理 #6230

Open

4 tasks

ToobLac added 3 commits August 29, 2026 21:15

update

769c438

Merge remote-tracking branch 'upstream/main' into mod-dep

436ca08

# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java

update

9a374e3

github-actions Bot added 100+ and removed 500+ labels Sep 4, 2026

update

0b131a7

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated

ToobLac added 2 commits September 8, 2026 19:40

update

42603e8

Merge remote-tracking branch 'upstream/main' into mod-dep

6dfdc82

Glavo reviewed Sep 8, 2026

View reviewed changes

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonManager.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java Outdated

do not verify dependency installation status for modpacks

f0c14f1

github-actions Bot added 500+ and removed 100+ labels Sep 8, 2026

invalidate addon manager after downloading

8977d7b

Glavo reviewed Sep 8, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/download/DownloadPage.java Outdated

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/DownloadPage.java

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/ModrinthRemoteAddonRepository.java

ToobLac and others added 2 commits September 8, 2026 21:17

update

3836cc7

Merge remote-tracking branch 'upstream/main' into mod-dep

dbc85ea

chatgpt-codex-connector Bot reviewed Sep 9, 2026

View reviewed changes

ToobLac added 2 commits September 10, 2026 21:58

Merge remote-tracking branch 'upstream/main' into mod-dep

473bb2a

# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/repository/CurseForgeRemoteAddonRepository.java

using platform-provided sha-1 hash

3de8abd

Glavo reviewed Sep 11, 2026

View reviewed changes

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/LocalAddonManager.java Outdated

ToobLac added 4 commits September 11, 2026 21:27

update

e5c7c3e

update

2d03e2c

Merge remote-tracking branch 'upstream/main' into mod-dep

588ff32

update

1dc6911

Uh oh!

Conversation

ToobLac commented Aug 22, 2026

Uh oh!

ToobLac commented Aug 24, 2026

Uh oh!

Glavo commented Aug 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Minecraft269 commented Aug 27, 2026

Uh oh!

Glavo commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Glavo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Glavo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glavo commented Sep 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

ToobLac Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chatgpt-codex-connector Bot commented Sep 7, 2026 •

edited

Loading