Repository navigation
Change label to "inc. soft navs" - #1375
Open
tunetheweb wants to merge 1 commit into
Open
tunetheweb wants to merge 1 commit into
tunetheweb wants to merge 1 commit into
Conversation
Contributor
|
Visit the preview URL for this PR (updated for commit 3d43729): https://httparchive--pr1375-soft-navs-label-3ovpspoq.web.app (expires Mon, 26 Oct 2026 08:53:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1069cba7974889c25bacf4f0a19ddb6735592729 |
| }, | ||
| { | ||
| "label": "Good Core Web Vitals (with soft navs)", | ||
| "label": "Good Core Web Vitals (inc. soft navs)", |
Contributor
There was a problem hiding this comment.
I was thinking to expand into incl., but I understand the confusion is about defining its additive definition.
+ version seems most straightforward.
Suggested change
| "label": "Good Core Web Vitals (inc. soft navs)", | |
| "label": "Good Core Web Vitals (+ soft navs)", |
WDYT?
Contributor
|
Let's also add details here: httparchive.org/config/techreport.json Lines 1514 to 1515 in 436ea0e Maybe just making 'soft havs' bold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had complaints that "(with soft navs)" and "(soft navs)" are ambiguous.