Follow-up from PR #1074 review (round 3). DeliveryOutcome.result classifies delivery as complete, partial, or error for streamed responses, but nothing consumes it: it sits behind a field-level #[allow(dead_code)] as disclosed groundwork.
The intended consumer is a delivery_result LowCardinality column on access_logs_raw, which would make truncated streamed deliveries visible in the dashboard (today a partial delivery and a complete one produce identical rows apart from resp_bytes). Additive schema evolution with a JSONPath and FORWARD_QUERY default, same path as the auction timeline offsets in #1076.
If no consumer lands, the fallback position from review is to remove DeliveryResult, classify_stream_delivery, and their tests rather than let the allow settle in permanently.
🤖 Generated with Claude Code
Follow-up from PR #1074 review (round 3).
DeliveryOutcome.resultclassifies delivery as complete, partial, or error for streamed responses, but nothing consumes it: it sits behind a field-level#[allow(dead_code)]as disclosed groundwork.The intended consumer is a
delivery_resultLowCardinality column onaccess_logs_raw, which would make truncated streamed deliveries visible in the dashboard (today a partial delivery and a complete one produce identical rows apart fromresp_bytes). Additive schema evolution with a JSONPath and FORWARD_QUERY default, same path as the auction timeline offsets in #1076.If no consumer lands, the fallback position from review is to remove
DeliveryResult,classify_stream_delivery, and their tests rather than let the allow settle in permanently.🤖 Generated with Claude Code