fix: reject negative proton isotope indexes - #256
Merged
fbaensch-beilstein merged 2 commits intoAug 19, 2026
Merged
Conversation
fbaensch-beilstein
approved these changes
Aug 19, 2026
fbaensch-beilstein
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nNumRemovedProtonsIsotopicGetStructFromINCHI()regression for public OSS-Fuzz issue488729177
Root cause
The single-proton cleanup path checked only that
iso_atw_diffwas no largerthan
NUM_H_ISOTOPES. Because the field is signed, the malformed inputInChI=1/T/q+1/i12-112Tproducediso_atw_diff == -112, passed that upperbound, and accessed the three-element array at index
-113.The public testcase reproduces on current
devas an ASan two-byte stackout-of-bounds read in
mark_alt_bonds_and_taut_groups(). Requiring a positivedelta before subtracting one makes the API reject the malformed string with
its normal
inchi_Ret_ERRORresult.Verification
after the patch
libinchitargets build successfullygit diff --checkpassesType of change
Checklist
./INCHI-1-TEST/build_with_cmake.sh all).editorconfig(4-space indent, LF, no trailing whitespace)ctestin thefull_buildtest dir)pytest INCHI-1-TEST/tests/test_executable)Related issues
Refs #209 (GOF #488729177 only; the issue also tracks two unrelated leaks).