Skip to content

refactor: rename release artifacts - #257

Merged
fbaensch-beilstein merged 4 commits into
devfrom
rename-release-artifacts
Aug 12, 2026
Merged

refactor: rename release artifacts#257
fbaensch-beilstein merged 4 commits into
devfrom
rename-release-artifacts

Conversation

@JanCBrammer

Copy link
Copy Markdown
Collaborator

This PR implements #197.

Include release tag (version) if available and abbreviate SHA.
@JanCBrammer JanCBrammer linked an issue Aug 11, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

Unit Test Coverage Report

Coverage Regression Summary

Metric PR (%) Base (%) Difference (pp)
Lines 21.3 21.3 +0.00
Branches 14.2 14.2 +0.00

Find details on the base coverage at https://iupac-inchi.github.io/InChI/coverage/index.html

Find details on this PR's coverage by downloading coverage-reports-31599202446 and opening html/index.html

@JanCBrammer JanCBrammer changed the title Rename release artifacts refactor: rename release artifacts Aug 11, 2026

@fbaensch-beilstein fbaensch-beilstein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup — the artifact naming is right and I verified the mechanics locally:

  • the new pinned hash matches GitHub's hashFiles algorithm (sha256 of the concatenated per-file sha256) for the updated build_matrix.json;
  • building demos/inchi_main/src on Linux produces exactly bin/libinchi.so.1.07 with SONAME=libinchi.so.1.07, and inchi_main's DT_NEEDED matches — so the new lib_path values are correct;
  • CI is unaffected: the full_build tree still gets the libinchi.so symlink next to the versioned file, so test_multithreading.py and both composite actions' default library-path keep resolving.

One security point, inline below, plus the same issue pre-existing further down the file.


Same injection at Create release (pre-existing, outside this diff).

gh release create ${{ github.ref_name }} \
--verify-tag \
--title "${{ github.ref_name }}" \

Here the tag can't be sanitised (--verify-tag needs the literal name), so quote it out of the script instead:

      - name: Create release
        shell: bash
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          TAG: ${{ github.ref_name }}
        # See https://cli.github.com/manual/gh_release_create.
        run: |
          gh release create "$TAG" \
          --verify-tag \
          --title "$TAG" \
          --notes "For details about this release have a look at the [CHANGELOG](INCHI-1-DOC/CHANGELOG.md)." \
          release_artifacts.zip cmake_configurations.zip

Not introduced by this PR, but fixing only the new step leaves the file inconsistent — worth doing both here or filing a follow-up.


Two non-blocking notes I'll leave as plain comments rather than change requests:

  1. The artifact now ships only libinchi.so.1.07 / libinchi.1.07.dylib with no unversioned libinchi.sodemos/inchi_main/src/CMakeLists.txt:102 copies $<TARGET_FILE:libinchi>, not the symlink. Correct for the bundled inchi_main, but it breaks anyone doing dlopen("libinchi.so") against a downloaded release. Intentional?
  2. The hash guard was already stale on dev: ae87ded… matches build_matrix.json as of 94aa402, but c612989 changed the matrix without re-pinning — so the Release workflow currently aborts at Verify build matrix. This PR incidentally fixes that. Since nothing in CI exercises release.yml, the pin rots invisibly; a one-line CI step recomputing and comparing it would catch the next one.

Comment thread .github/workflows/release.yml Outdated
Comment thread INCHI-1-SRC/INCHI_API/libinchi/src/CMakeLists.txt
@fbaensch-beilstein
fbaensch-beilstein merged commit 8e8c33f into dev Aug 12, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restructure directory for release artifacts

2 participants