Defer CSRF counter measure ID validation - #403
Closed
lippserd wants to merge 1 commit into
Closed
Conversation
Require an ID only when request metadata cannot establish its origin and token-based validation is necessary. Safe and cross-site requests can then take their existing paths without a configured ID.
Member
|
Please provide an example where you need this. My gut's feeling isn't good here and I want the previous author's feedback as well. |
jrauh01
requested changes
Aug 3, 2026
| } | ||
|
|
||
| if ($uniqueId === null) { | ||
| throw new Error('No CSRF counter measure ID set'); |
Contributor
There was a problem hiding this comment.
Please add @throws to document this error.
| }; | ||
| } | ||
|
|
||
| private function makeFormWithoutId(bool $disabled = false): Form |
Contributor
There was a problem hiding this comment.
Personally I think you should remove the $disabled param and explicitly disable CSRF protection in the test itself via:
$form = $this->makeFormWithoutId();
$form->disableCsrfCounterMeasure();It's only used once anyway, and this would make it clearer at the call site.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require an ID only when request metadata cannot establish its origin and token-based validation is necessary. Safe and cross-site requests can then take their existing paths without a configured ID.