ENH: Add AdaptiveDenoising remote module CID blobs (3 files, 0.71 MiB)#48
Open
hjmjohnson wants to merge 1 commit intogh-pagesfrom
Open
ENH: Add AdaptiveDenoising remote module CID blobs (3 files, 0.71 MiB)#48hjmjohnson wants to merge 1 commit intogh-pagesfrom
hjmjohnson wants to merge 1 commit intogh-pagesfrom
Conversation
Pre-uploads test fixtures for the upcoming ITKAdaptiveDenoising
remote-module ingest:
bafkreiafwnstu4vzkrl7gpt73tl3q53ywpdylbs2d4emezgzutj2thoyfy
r16slice.nrrd (test/Input, 239K)
bafkreigltzq46r5ojiiyel37egvlosnxxgyth6ppwckzjtuxyywtlijoii
r16denoised_mean_squares.nrrd (test/Baseline, 256K)
bafkreickjyvdwmq6eyz76e7cukkegm4dd75raimxj4pag2o6bkanvbofwm
r16denoised_pearson_correlation.nrrd (test/Baseline, 239K)
CIDs computed via 'ipfs add --cid-version=1 --raw-leaves'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-uploads test fixtures for the upcoming
ITKAdaptiveDenoisingremote-module ingest. The fixtures live in the upstream repo as raw
.nrrdfiles (not content-links); ITK's contributing rules forbidraw binaries in
test/, so they need to be re-published as CIDblobs here before the in-tree ingest PR can land.
bafkreiafwnstu4vzkrl7gpt73tl3q53ywpdylbs2d4emezgzutj2thoyfytest/Input/r16slice.nrrdbafkreigltzq46r5ojiiyel37egvlosnxxgyth6ppwckzjtuxyywtlijoiitest/Baseline/r16denoised_mean_squares.nrrdbafkreickjyvdwmq6eyz76e7cukkegm4dd75raimxj4pag2o6bkanvbofwmtest/Baseline/r16denoised_pearson_correlation.nrrdCIDs were computed via
ipfs add --cid-version=1 --raw-leavesandverified after copy: every uploaded file's recomputed hash matches
its filename.
Why these are needed
The upstream
ntustison/ITKAdaptiveDenoisingships these fixturesinline in git rather than via the ExternalData / content-link
convention. The standard ITK ingest pipeline (v4) faithfully
reproduces upstream content; without
.cidstubs inITKTestingData, the in-tree ingest PR's tests would carry rawbinaries and fail the contributor-policy gate
(
Utilities/Maintenance/RemoteModuleIngest/AGENTS.md, decision 3).Once these blobs land here, the in-tree ingest PR will replace the
raw
.nrrdfiles with three small.cidstubs that point at theseCIDs, and
ITKExternalDatawill resolve them through the standardITKTestingDatamirror at fetch time.