CDFs for EB announcements - #6639
Conversation
coot
added
the
leios
|
|
||
| data Config = Config { numOfDataPoints :: Int } | ||
|
|
||
| -- | Default `Config` keeps `k/2` data points. |
There was a problem hiding this comment.
The proportionality to k is easier to justify for some CDFs than for others, but it's probably fine for most?
There was a problem hiding this comment.
But one other option is to just force each callers to choose a number
There was a problem hiding this comment.
That's how it's done, we just happen to provide a defaultConfig which is used by all applications (block-fetch and leios announcements). Do you have a better value for leios announcment?
| , ("leios.eb.announcement.delay.cdf1600ms", "probability for EB announcemement to complete within 1600ms") | ||
| , ("leios.eb.announcement.delay.cdf1800ms", "probability for EB announcemement to complete within 1800ms") | ||
| , ("leios.eb.announcement.delay.cdf2000ms", "probability for EB announcemement to complete within 2000ms") | ||
| , ("leios.e.b.announcement.late.all", "number of late EB announcements that took longer than 2s: all peers are included") |
There was a problem hiding this comment.
I wasn't expecting "all peers are included" here. These metrics are driven by TraceLeiosAnnouncementAccepted, which is deduped---it only fires the first time some announcement arrives.
There was a problem hiding this comment.
all peers are included
What is this supposed to mean? I still don't understand
There was a problem hiding this comment.
Also, there's a typo in the name: .e.b.
2c5ed69 to
22d7144
Compare
* Moved to a new module * Provide re-usable API This is a preparation work for re-using the CDF calculations for Leios.
nfrisby
left a comment
nfrisby
left a comment
There was a problem hiding this comment.
There are some "typo"-level minor issues in this thread https://github.com/IntersectMBO/cardano-node/pull/6639/changes#r3722072409 but otherwise looks good to me. Thanks for addressing my comments 👍
2 participants
Description
Checklist
See Running tests for more details
CHANGELOG.mdfor affected packagecardano-node-chairman,cardano-submit-apiandcardano-testnetinstead need achangelog fragment in
<package>/.changes/, because theirCHANGELOG.mdis generatedfrom fragments at release time. Copy
_TEMPLATE.ymlfrom that directory, or runnix run github:input-output-hk/cardano-dev#herald -- new.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.