Add valueOf golden coverage in Spec.Data.Budget - #7800
Merged
Conversation
Contributor
Unisay
force-pushed
the
yura/issue-2242-optimal-valueof
branch
from
May 28, 2026 11:28
0ac70fa to
cd7c252
Compare
Unisay
force-pushed
the
yura/issue-2242-valueof-golden-gate
branch
from
May 28, 2026 11:29
592ee78 to
3f78512
Compare
Unisay
force-pushed
the
yura/issue-2242-optimal-valueof
branch
from
May 28, 2026 11:43
cd7c252 to
8271c9e
Compare
Unisay
force-pushed
the
yura/issue-2242-valueof-golden-gate
branch
from
May 28, 2026 11:43
3f78512 to
614ac9e
Compare
Unisay
force-pushed
the
yura/issue-2242-optimal-valueof
branch
from
May 28, 2026 11:50
8271c9e to
613670c
Compare
Unisay
force-pushed
the
yura/issue-2242-valueof-golden-gate
branch
from
May 28, 2026 11:50
614ac9e to
ef47fc2
Compare
Unisay
force-pushed
the
yura/issue-2242-optimal-valueof
branch
from
May 29, 2026 10:35
613670c to
b4d1df4
Compare
Unisay
force-pushed
the
yura/issue-2242-valueof-golden-gate
branch
from
May 29, 2026 10:36
ef47fc2 to
d97a546
Compare
Adds a PIR-readable snapshot and four budget snapshots for the new `valueOf` implementation, registered alongside the existing golden coverage for `gt`, `geq`, and `currencySymbolValueOf`. Scenarios: - valueOf_hit_first: ada-like first-position lookup, exercises short-circuit on the first outer step. - valueOf_hit_middle: key at the middle of the outer map. - valueOf_hit_last: key at the last entry, full outer scan. - valueOf_miss: absent key, full scan with no inner walk. These tests catch regressions in `valueOf` compilation and cost that would otherwise surface only through downstream callers (`currencySymbolValueOf`, `assetClassValueOf`, `geq`, etc.).
Unisay
force-pushed
the
yura/issue-2242-valueof-golden-gate
branch
from
August 10, 2026 15:04
d97a546 to
fd2ef05
Compare
Unisay
marked this pull request as ready for review
August 10, 2026 15:04
Unisay
enabled auto-merge (squash)
August 10, 2026 16:01
zliu41
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a PIR snapshot and four budget goldens for
PlutusLedgerApi.V1.Data.Value.valueOf, next to the existing ones forgt,geq, andcurrencySymbolValueOf. The scenarios pin the cost of a hit on the first, middle, and last outer entry plus a miss, so a regression invalueOfsurfaces here instead of downstream incurrencySymbolValueOf,assetClassValueOf, orgeq.Follow-up to #7797, which landed the implementation and a differential CEK-vs-Haskell property test but left the compiled shape and cost unpinned.