Stop managed_array from accidentally changing C++ types#155
Merged
Conversation
Storing non-POD types in char buffers is unsafe. * Ensure alignments are compatible with desired type. * Ensure raw data is copied with memcpy Otherwise, the list entries are created raw and placement-constructed as one type, which is changed when they're copied by the copy constructor of T (different type). For POD data this wouldn't matter, but here it changes the vtable pointer and indirectly causes an OOB write.
Owner
|
With the new CMake version, the pipeline for Win64 seems broken; I will fix this and then merge this PR. |
Contributor
Author
|
Thanks, I spotted something was up with the CI but I'm not a CMake user so didn't try and fix. |
Ink Proof ResultsThese results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing non-POD types in char buffers is unsafe.
memcpyOtherwise,
_list_handoutsplacement-constructs entries as one type (list_impl) which is changed when they're copied by the copy constructor of T (list_interface, different type). For POD data this wouldn't matter, but here it changes the vtable pointer and indirectly causes an OOB write.This crashed my memory allocator, which is how I spotted it.