Recycle workers with bad init times - #176
Draft
christiangnrd wants to merge 1 commit into
Draft
Conversation
christiangnrd
marked this pull request as draft
September 2, 2026 18:24
christiangnrd
force-pushed
the
init
branch
3 times, most recently
from
September 3, 2026 13:22
c6603ff to
82f1823
Compare
christiangnrd
force-pushed
the
init
branch
2 times, most recently
from
September 11, 2026 13:00
2fbeb01 to
f8af12b
Compare
christiangnrd
removed this pull request from stack #180
September 11, 2026 13:03
christiangnrd
added this pull request to stack #184
September 11, 2026 13:03
…tart The slow init warning already tracks the cost of a fresh worker: once a warm init exceeds SLOW_INIT_FACTOR times that, spawning a new worker is cheaper than keeping the bloated heap of the current one (e.g. under macOS memory pressure, issue #124). Recycle such pool workers in addition to warning, print the worker id and the offending init time in yellow, and extend the slow init testset to check the recycle and the output. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing init times usually means macOS is under too much memory pressure, this should help prevent pathological increase in GC time before starting a new testset on a worker.
Keeps track of the lowest non-custom worker init and if a test took longer than double that time, recycle it. In verbose mode, init time turns yellow when a worker is to be recycled for this reason
One design question is if we should expose the init time multiplier value as an argument to
runtests. I'm leaning towards no