feat(cloud-agent): send saved diff reviews to chats - #5817
Open
eshurakov wants to merge 7 commits into
Open
Conversation
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 1, 2026 19:41
987fa7c to
14b8fdb
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
2 times, most recently
from
September 2, 2026 12:52
b22f8fa to
a71610f
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 07:47
a71610f to
4cf9d58
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 07:50
4cf9d58 to
2c2abda
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 11:37
2c2abda to
10eaade
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 12:31
10eaade to
3dd0a0e
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 12:58
3dd0a0e to
7cac306
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 3, 2026 20:21
7cac306 to
8467a86
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 7, 2026 20:17
8467a86 to
6f4a8c9
Compare
1 task
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
2 times, most recently
from
September 7, 2026 20:45
fcfc693 to
30bc04e
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 7, 2026 20:53
30bc04e to
26658b4
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 8, 2026 10:29
26658b4 to
9a0611a
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 8, 2026 10:55
9a0611a to
97ac3a6
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 8, 2026 12:29
97ac3a6 to
24ccbf4
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 8, 2026 12:57
24ccbf4 to
c25db45
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 9, 2026 21:33
c25db45 to
11e3830
Compare
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 10, 2026 08:34
11e3830 to
cce3370
Compare
Add inline line-range comments, compact review summary, JSON agent payload, condensed chat card, and IndexedDB drafts.
eshurakov
force-pushed
the
eshurakov/spry-mangrove
branch
from
September 10, 2026 08:42
cce3370 to
30c4b5f
Compare
ConversationMessages loads MessageBubble, which imports worktree-review. Jest cannot parse @pierre/diffs ESM, so the suite failed in CI.
eshurakov
marked this pull request as ready for review
September 10, 2026 09:06
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Previous Review Summaries (4 snapshots, latest commit ce81aaf)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ce81aaf)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous review (commit 23a0bc6)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryA generation-mismatch IndexedDB clear can delete a newer in-progress review draft after accept or discard. Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Previous review (commit 4671023)Status: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Executive SummaryA generation-mismatch IndexedDB clear can delete a newer in-progress review draft after accept or discard. Overview
Issue Details (click to expand)WARNING
Files Reviewed (8 files)
Previous review (commit 82fa7e4)Status: 4 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Files Reviewed (40 files)
Reviewed by grok-4.6 · Input: 188.2K · Output: 19.2K · Cached: 411.6K Review guidance: REVIEW.md from base branch |
Do not send a silent subset, rebase other-chat comments, wipe unsaved editors while loading, or resurrect an accepted draft from a late IDB save.
A late preparing save must rewrite the in-memory draft, not clear a newer one.
Send the agent the unified rows the user selected, including both deletions and additions in a replacement hunk. Derive the stored range from the quote; rebase on unique quote text.
| const lineNumber = Number(row.getAttribute('data-line')); | ||
| const unifiedIndexValue = row.getAttribute('data-line-index'); | ||
| const unifiedIndexPart = unifiedIndexValue?.split(',')[0]?.trim(); | ||
| const unifiedIndex = unifiedIndexPart ? Number(unifiedIndexPart) : Number.NaN; |
Contributor
There was a problem hiding this comment.
WARNING: Truthy check treats unified index 0 as missing
unifiedIndexPart ? Number(unifiedIndexPart) is false for "0", so the first unified row (data-line-index="0,0") is rejected as a hidden-line gap. Any comment selection that includes the first rendered row fails, including the mixed-side cases this commit adds.
Suggested change
| const unifiedIndex = unifiedIndexPart ? Number(unifiedIndexPart) : Number.NaN; | |
| const unifiedIndex = unifiedIndexPart === undefined || unifiedIndexPart === '' ? Number.NaN : Number(unifiedIndexPart); |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
No manual browser or live-provider tests were rerun during this restack. Existing pending work was preserved in named stash/backup refs; local handoff and evidence files remain unchanged and excluded.
Visual Changes
Adds direct diff selection, inline feedback, draft review controls, and a review dialog. No screenshots were captured or uploaded during this restack.
Reviewer Notes
Stacked on #5816 (eshurakov/boundless-sphinx). Three commits, including GitHub-style review UX. The merge preserves both commit-card and review wiring, plus upstream autoCommit: true and expected-worktree authorization checks.
Final combined verification passed: web lint, full web typecheck with tRPC declaration build, and eight setup-free Jest suites / 241 tests, including the native review wrappers. All 29 terminal-navigation tests pass after adding the missing review-boundary mocks to their existing fixture; this correction changes no product behavior. The standalone native review suites (77 tests) and review-send/client suites (131 tests) also passed earlier. Formatting, whitespace, and independent merge review passed. No database setup or browser evidence is implied by these isolated tests.