Fixed compilation issue with fmt > 11 - #468
Merged
Merged
Conversation
Contributor
Author
|
P.S. the steps suggested by the DCO bot don't work as I do not have permission to push to the repo |
Member
|
@hamdannawaz582 you need to push to your own branch planar-project:fix-fmt-format |
…rmat Signed-off-by: Hamdan Nawaz <hamdannawaz582@gmail.com>
hamdannawaz582
force-pushed
the
fix-fmt-format
branch
from
July 26, 2026 12:53
f390326 to
801a88e
Compare
Member
|
Looks good - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt has deprecated using fmt::format by including fmt/core.h (see this file, this results in Kompute not compiling as a vcpkg project when its flags are set to
KOMPUTE_OPT_USE_BUILT_IN_FMT=OFFas vcpkg defaults to version 12.2.This PR fixes this issue by including fmt/format.h in the 2 files where fmt::format is used directly.
Confirmed to compile on linux both as a vcpkg project and via the standalone dependency resolution which still uses fmt 11.