Skip to content

Differentiate between high/lowpass for the saturator - #16

Closed
Hasster1 wants to merge 1 commit into
LMMS:ladspafrom
Hasster1:ladspa
Closed

Hasster1 wants to merge 1 commit into
LMMS:ladspafrom
Hasster1:ladspa

Conversation

@Hasster1

Copy link
Copy Markdown

@tresf

tresf commented Oct 1, 2026

Copy link
Copy Markdown
Member

Thanks! Our submodule is based on Calf Studio Gear's, it's an LADSPAv1 port of their LV2 plugins. It appears that they do not differentiate between these values in upstream. Would you consider submitting a patch there?

https://github.com/calf-studio-gear/calf/blob/ecbbb2d68a5066a9ee30e56c6a20635a20f03ee4/src/metadata.cpp#L1269-L1273

@Hasster1

Hasster1 commented Oct 1, 2026

Copy link
Copy Markdown
Author

Would you consider submitting a patch there?

Sure!

@Hasster1

Hasster1 commented Oct 2, 2026

Copy link
Copy Markdown
Author

Forgot to put a link to that PR here - calf-studio-gear#411

@JohannesLorenz

Copy link
Copy Markdown

@Hasster1 Thanks for the submission on calf/calf. I merged your PR there. So I assume we can now close this PR and either make a PR from calf/calf:master to LMMS/veal:ladspa, or merge it manually .

@tresf what's your opinion, should the ladspa branch be protected against pushes?

@tresf

tresf commented Oct 13, 2026

Copy link
Copy Markdown
Member

@Hasster1 Thanks for the submission on calf/calf. I merged your PR there. So I assume we can now close this PR and either make a PR from calf/calf:master to LMMS/veal:ladspa, or merge it manually .

@tresf what's your opinion, should the ladspa branch be protected against pushes?

Good question. I think it can probably receive the patches directly but I understand the whole "branch protection" philosophy which is especially volatile for submodules as it can break past versions if we accidentally rewrite history.

I'm fine either way. Since 100s of people have the submodule locally we can probably safely push to it and beg other devs to restore mistakes if/when they occur. Simplest solution I think.

@JohannesLorenz

Copy link
Copy Markdown

Simplest solution I think.

Just merged locally but couldn't push:

remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/ladspa.
remote: 
remote: - Changes must be made through a pull request.
To github.com:LMMS/veal.git
 ! [remote rejected] ladspa -> ladspa (protected branch hook declined)
error: failed to push some refs to 'github.com:LMMS/veal.git'

So I just created #17 using this link.

@JohannesLorenz

Copy link
Copy Markdown

@Hasster1 Since #17 has been merged (sorry for the delay!) I guess we can close this PR here, and also, you can open a PR on LMMS/lmms to update the submodule pointing to 06056c3.

@Hasster1

Hasster1 commented Nov 3, 2026

Copy link
Copy Markdown
Author

I guess this can be closed now.

@Hasster1 Hasster1 closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repeating knob names in Saturator

3 participants