Line normalization for devcontainer hash - #191
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/hash_git_files.py:
- Around line 92-93: Update the checksum logic around the file hashing flow to
avoid CRLF-to-LF normalization for binary files. Apply normalization only to an
explicit, reliably identified set of text paths, while hashing all other files’
raw bytes so binary content changes always affect the checksum; keep the
existing checksum accumulation behavior unchanged.
- Around line 92-93: Update the hashing logic in the file-processing and
extra-path hashing flows to read files in bounded chunks instead of calling
read_bytes(). Normalize CRLF incrementally, carrying a trailing carriage return
between chunks so split "\r\n" sequences are handled correctly, and feed each
normalized chunk into zlib.adler32 while preserving the existing checksum
behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1a20513f-f176-4210-9bdf-5c4fbd972575
📒 Files selected for processing (2)
.github/workflows/hash_git_files.pyAGENTS.md
2 participants
Why is this change necessary?
When developers are not using a devcontainer and are running on windows, the CRLF vs LF generated different hashs
How does this change address the issue?
Normalizes line endings
What side effects does this change have?
N/A
How is this change tested?
Downstream repo
Other
Tweaked AGENTS.md to stop Coderabbit from telling us to use kwargs for test functions
Summary by CodeRabbit
Bug Fixes
Documentation