Repository navigation
adbc: add CATALOG support with qualified scans and schema probe fallback - #92
Merged
Merged
Conversation
- Accept optional CATALOG attach option for 3-level namespaces (e.g. Databricks Unity Catalog), threaded through ADBCCatalog and ADBCConnector::qualifiedTableRef. - Build a prequalified FROM clause once per table and propagate it via ADBCTableScanInfo (fromClause + backtickIds) through catalog entry and scan bind, avoiding double-quoting. - Use backtick quoting for catalog-qualified refs and columns: with ANSI mode off (Spark/Databricks), double-quoted ids are string literals and fail with PARSE_SYNTAX_ERROR. - Fall back to SELECT * WHERE 1=0 statement probe when AdbcConnectionGetTableSchema is unsupported (e.g. Databricks), reading the Arrow stream schema instead. - Switch connector mutex to recursive_mutex since schema probe re-enters via executeQuery under the same lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional CATALOG attach option for 3-level namespaces (e.g. Databricks Unity Catalog).
Legacy behavior unchanged when CATALOG is empty (bare double-quoted table).
Review notes / follow-ups: