test: use IUserFolder mocks for Nextcloud 36 - #8329
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
fix/nc36-user-folder-test-mocks
branch
from
September 10, 2026 15:12
2e7c986 to
1517052
Compare
github-actions
Bot
force-pushed
the
fix/nc36-user-folder-test-mocks
branch
from
September 10, 2026 15:16
67f87ef to
7c47f6d
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/nc36-user-folder-test-mocks
branch
from
September 10, 2026 15:18
7c47f6d to
dffce3f
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nextcloud 36 changed
IRootFolder::getUserFolder()to returnIUserFolder.Several unit tests on
mainstill returnedFolderorIRootFoldermocks fromgetUserFolder(). PHPUnit now rejects these return values and this caused the Nextcloud 36 PHPUnit jobs to fail.This PR updates only mocks used as
getUserFolder()results to useIUserFolder.Each changed test file has its own signed-off commit.
Testing
git diff --checkphp -lfor each changed PHP test fileThe other
AccountServiceTestfailures seen in #8142 are related to the tests added by that PR and are not part of this fix.