refactor: extract PKCS#12 credentials to separate interface

lib/Handler/SignEngine/IPkcs12SignEngineHandler.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: Copyright (c) 2026 Rolf39
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Libresign\Handler\SignEngine;
+
+interface IPkcs12SignEngineHandler extends ISignEngineHandler {
+	public function setCertificate(string $certificate): self;
+	public function getCertificate(): string;
+	public function readCertificate(): array;
+	public function setPassword(string $password): self;
+	public function getPassword(): string;
+}

lib/Handler/SignEngine/ISignEngineHandler.php

@@ -13,11 +13,6 @@
 interface ISignEngineHandler {
 	public function setInputFile(File $inputFile): self;
 	public function getInputFile(): File;
-	public function setCertificate(string $certificate): self;
-	public function getCertificate(): string;
-	public function readCertificate(): array;
-	public function setPassword(string $password): self;
-	public function getPassword(): string;
 	public function sign(): File;
 	public function getSignedContent(): string;
 	public function getSignatureParams(): array;

lib/Handler/SignEngine/SignEngineHandler.php

@@ -24,7 +24,7 @@
 use OCP\IL10N;
 use Psr\Log\LoggerInterface;
 
-abstract class SignEngineHandler implements ISignEngineHandler {
+abstract class SignEngineHandler implements IPkcs12SignEngineHandler {
 	private File $inputFile;
 	protected string $certificate = '';
 	private string $pfxFilename = 'signature.pfx';

lib/Service/SignFileService.php

@@ -36,6 +36,7 @@
 use OCA\Libresign\Handler\PdfTk\Pdf;
 use OCA\Libresign\Handler\SignEngine\ISignEngineHandler;
 use OCA\Libresign\Handler\SignEngine\Pkcs12Handler;
+use OCP\Libresign\Handler\SignEngine\IPkcs12SignEngineHandler;
 use OCA\Libresign\Handler\SignEngine\SignEngineFactory;
 use OCA\Libresign\Handler\SignEngine\SignEngineHandler;
 use OCA\Libresign\Helper\JSActions;
@@ -87,7 +88,7 @@
 	private string $userUniqueIdentifier = '';
 	private string $friendlyName = '';
 	private ?IUser $user = null;
-	private ?ISignEngineHandler $engine = null;
+	private ?IPkcs12SignEngineHandler $engine = null;
 
 	public function __construct(
 		protected IL10N $l10n,
@@ -877,7 +878,7 @@
 		$this->signRequest->setSignedHash($hash);
 		$this->signRequest->setStatusEnum(\OCA\Libresign\Enum\SignRequestStatus::SIGNED);
 
 		$certificateInfo = $this->getEngine()->readCertificate();
 		$this->storeCertificateInfoInMetadata($certificateInfo);
 
 		$this->signRequestMapper->update($this->signRequest);
@@ -929,7 +930,7 @@
 		$certificateSerialNumber = null;
 		if ($this->signWithoutPassword) {
 			try {
 				$certificateInfo = $this->getEngine()->readCertificate();
 				if (isset($certificateInfo['serialNumber']) && is_string($certificateInfo['serialNumber'])) {
 					$certificateSerialNumber = $certificateInfo['serialNumber'];
 				} else {
@@ -1179,7 +1180,7 @@
 
 	protected function readCertificate(): array {
 		return $this->getEngine()
 			->readCertificate();
 	}
 
 	/**
@@ -1228,20 +1229,20 @@
 		return strcasecmp($file->getExtension(), 'pdf') === 0;
 	}
 
 	protected function getEngine(): ISignEngineHandler {
 		if (!$this->engine) {
 			$originalFile = $this->getFileToSign();
 			$this->engine = $this->identifyEngine($originalFile);
 
 			$this->configureEngine();
 		}
 		return $this->engine;
 	}
 
 	private function configureEngine(): void {
 		$this->engine
 			->setInputFile($this->getFileToSign())
 			->setCertificate($this->getOrGeneratePfxContent($this->engine))
 			->setPassword($this->password);
 
 		if ($this->engine::class === Pkcs12Handler::class) {