[stable35] feat: add frontend support for signer geolocation - #8359
Merged
Conversation
Capture agreed terms from the frontend geolocation design so optional mode is not confused with soft collection. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Register disabled/optional/required radios and clarify that optional lets requesters require device location for selected signers. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Show the requester toggle only when geolocation mode is optional and persist geolocationRequired on signature requests. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Request browser location only when frozen requirement is required, with privacy consent, fresh high-accuracy options, and retry/exit on failure without sending non-collected statuses. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Render stored coordinates in SignerDetails and EnvelopeValidation as device-reported location, without map visualization. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Add focused coverage for the privacy dialog, successful collected payload submit, failure retry/dismiss, cancel without collection, and the disabled path that skips geolocation. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Expose and assert device-reported location formatting in EnvelopeValidation for present and absent geolocation metadata. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Drop collected coordinates when signature submit fails so the next attempt reopens the privacy dialog and fetches a fresh position. Also share CollectedGeolocation typing and resolve frozen requirement via a helper. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Add an explicit not-verified physical presence disclaimer and TRANSLATORS comments on the audit label. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Use glossary wording on the requester toggle and prefer logical CSS properties for the geolocation wrapper. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Add coverage for frozen requirement resolution, stale-after-failed-submit, distinct collection failure messages, absent metadata, and the audit disclaimer. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Do not overwrite an existing geolocationRequirement freeze when later request saves omit geolocationRequired. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Re-send and restore the requester toggle from metadata.geolocationRequirement so notify/update no longer drops a required freeze. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Add regression coverage for omitted-flag preservation, metadata rehydration, and toggle restore when editing. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Show only the section label when collapsed, and reveal latitude, longitude, and the physical-presence disclaimer inside the expandable region. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Use the file policy snapshot for the requester toggle, show locale-aware accuracy with a local copy-coordinates action, and drop CONTEXT.md. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
vitormattos
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #8327