Skip to content

feat: show visible signature information in signer validation details - #8361

Merged
vitormattos merged 2 commits into
LibreSign:mainfrom
vdriga85:codex/8326-visible-signature
Sep 11, 2026
Merged

feat: show visible signature information in signer validation details#8361
vitormattos merged 2 commits into
LibreSign:mainfrom
vdriga85:codex/8326-visible-signature

Conversation

@vdriga85

Copy link
Copy Markdown
Contributor

Closes #8326.

Following the backend changes merged in #8332, this PR adds “Visible signature: Yes/No” to the details of signed signers.

The value comes directly from signer.visibleElements:

  • Yes when the array contains at least one element.
  • No when the array is empty or absent.

The field is displayed as ordinary metadata, outside the validation-status section. It does not change signature validation or introduce warnings. For envelopes, it uses the signer data for each individual document.

No backend changes or additional matching logic are included.

Testing

  • 159 focused tests passed across SignerDetails, DocumentValidationDetails, and SignersList.
  • TypeScript checking and focused ESLint passed.
  • Production build passed in Linux.
  • Manually checked the original signed document: “Visible signature: Yes” is displayed, and the document remains valid.

The tests cover one or multiple visible elements, empty and missing arrays, unsigned signers, collapsed details, and per-document signer data.

The existing Stylelint errors and warnings also occur on the unchanged base revision; this PR does not modify those styles.

Signed-off-by: Volodymyr Dryha <265930699+vdriga85@users.noreply.github.com>
@vdriga85
vdriga85 requested a review from a team as a code owner September 11, 2026 07:59
@github-project-automation github-project-automation Bot moved this to 0. Backlog in Roadmap Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

I've completed the frontend change using signer.visibleElements directly, as you suggested.

The Yes/No field appears in the signed signer's details, outside the validation-status section. No additional matching logic or backend changes were needed.

The focused tests and production build passed. I also checked the original signed document manually: it now shows “Visible signature: Yes”, while the document remains valid.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/components/validation/SignerDetails.vue 52.08% <100.00%> (+12.20%) ⬆️

... and 220 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/components/validation/SignerDetails.vue Outdated
@github-project-automation github-project-automation Bot moved this from 0. Backlog to 1. to do in Roadmap Sep 11, 2026
@vitormattos

Copy link
Copy Markdown
Member

Could you also add a screenshot of the signer details showing the new Visible signature: Yes/No field?

Since this PR changes the validation UI, a screenshot would make the visual result easier to review and would also help document the expected behavior in the PR.

vdriga85 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Signed-off-by: Volodymyr Dryha <265930699+vdriga85@users.noreply.github.com>
@vitormattos

Copy link
Copy Markdown
Member

Thanks! The change looks good now.

Just a small tip for future PRs: when adding screenshots on GitHub, you can attach the image directly to the comment instead of putting the screenshot inside a PDF.

You can copy the screenshot to your clipboard and press Ctrl+V in the GitHub comment field, or drag and drop the image file into the comment. GitHub will upload it and show the image directly in the PR, which makes visual changes much easier to review.

The implementation and tests look good to me. Thanks for the update!

@vitormattos
vitormattos merged commit f0b911f into LibreSign:main Sep 11, 2026
63 checks passed
@github-project-automation github-project-automation Bot moved this from 1. to do to 4. to release in Roadmap Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

Show visible signature information in signer validation details

3 participants