feat: show visible signature information in signer validation details - #8361
Conversation
Signed-off-by: Volodymyr Dryha <265930699+vdriga85@users.noreply.github.com>
|
I've completed the frontend change using The Yes/No field appears in the signed signer's details, outside the validation-status section. No additional matching logic or backend changes were needed. The focused tests and production build passed. I also checked the original signed document manually: it now shows “Visible signature: Yes”, while the document remains valid. |
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 220 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Could you also add a screenshot of the signer details showing the new Since this PR changes the validation UI, a screenshot would make the visual result easier to review and would also help document the expected behavior in the PR. |
|
Done, fixed. |
Signed-off-by: Volodymyr Dryha <265930699+vdriga85@users.noreply.github.com>
|
Thanks! The change looks good now. Just a small tip for future PRs: when adding screenshots on GitHub, you can attach the image directly to the comment instead of putting the screenshot inside a PDF. You can copy the screenshot to your clipboard and press The implementation and tests look good to me. Thanks for the update! |
Closes #8326.
Following the backend changes merged in #8332, this PR adds “Visible signature: Yes/No” to the details of signed signers.
The value comes directly from
signer.visibleElements:The field is displayed as ordinary metadata, outside the validation-status section. It does not change signature validation or introduce warnings. For envelopes, it uses the signer data for each individual document.
No backend changes or additional matching logic are included.
Testing
The tests cover one or multiple visible elements, empty and missing arrays, unsigned signers, collapsed details, and per-document signer data.
The existing Stylelint errors and warnings also occur on the unchanged base revision; this PR does not modify those styles.