Repository navigation
[stable35] fix: preserve frozen signing footer and validation URL - #9337
Merged
Merged
Conversation
Later footer policy changes, locks and the validator no longer apply to it. Signed-off-by: Paulo Raoni <raoni_jkd@hotmail.com>
Signed-off-by: Paulo Raoni <raoni_jkd@hotmail.com>
Signed-off-by: Paulo Raoni <raoni_jkd@hotmail.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
fix: reject unauthorized validation URL persistence Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> [skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
marked this pull request as ready for review
November 3, 2026 03:13
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug-fix-only backport of the footer integrity fixes from #9217 to
stable35. Related to #8715, but not a backport of the policy-lifecycle architecture intended for Nextcloud 36.Confirmed defects in stable35
SignFileService::getPdfToSign()passed the stored footer through a live policy resolution, andbuildValidationUrl()independently read the current policy. The resulting stamp/QR code and validation URL could differ from the value established for the request.add_footerin core-flow synchronization. As a result, changes selected for an existing, never-sent draft could silently fail to update the stored snapshot. That draft-only omission is corrected without changing frozen requests.Fixes (limited to stable35 behavior)
policy_snapshot.add_footer.effectiveValuewhen signing a frozen request, both for the PDF stamp and for the signature validation URL. Fall back to current policy resolution for never-sent drafts and legacy sent requests without a stored footer.policy_snapshot_frozen_atmarker already backported in [stable35] fix(stable35): keep signature rejection frozen after signing starts #8993 and retain a status-based fallback for legacy records; documents inherit the envelope's frozen state. The helper is local to the stable35-compatible file-policy path, without introducing the main-branchPolicySpeclifecycle API.validationSiterequest/personal-preference overrides while allowing authorized administrative policy values to be inherited.Explicit exclusions
signature_flowsemantics.docmdpor signature-rejection behavior changes, database migrations, public response-contract additions, broad dependency upgrades, or generalized policy-engine refactor.Regression and verification
23e327c5(signed with DCO). Wait for every required check to pass before merging.Backport note
The automated cherry-pick history contains one empty commit (
5e0cdb7); its diff is empty. It is kept to avoid rewriting already published signed history. The effective PR diff should be reviewed independently from the commit count.Merge is intentionally left to a human reviewer; no automatic merge requested.