feat(demo): add duplicate button so duplicating is testable - #107
Open
nva138 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
vitormattos
requested changes
Sep 11, 2026
Comment on lines
+62
to
+63
| await page.getByTitle("Duplicate").click(); | ||
| await expect(page.locator(".signature-box")).toHaveCount(2); |
Member
There was a problem hiding this comment.
Could we also verify that the new element is actually a copy of the original one?
Checking only that there are two .signature-box elements would also pass if the duplicate action accidentally created a new default signature instead of copying the selected element. It would be useful to compare an observable property of both elements, such as their content/size, while still allowing the expected position offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82. I didn't want to leave the duplicate interaction unfinished, so I added the button myself, hope thats okay. Now the duplicate test passes too.