MDEV-39861 innodb_log_recovery_target wrongly opens log in read-write mode#5185
Conversation
|
|
There was a problem hiding this comment.
Code Review
This pull request modifies the file creation logic in log0recv.cc by removing the int{} cast from i->second.access and adding recv_sys.rpo as an alternative condition. The reviewer points out that removing the cast could lead to compilation issues if access is a strongly-typed enum, and suggests comparing it directly to READ_ONLY for improved readability and type safety.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
… mode log_t::archived_switch_recovery_prepare(): Observe recv_sys.rpo similar to what recv_sys_t::find_checkpoint() does.
log_t::archived_switch_recovery_prepare(): Observerecv_sys.rposimilar to whatrecv_sys_t::find_checkpoint()does.This is based on b98be03 from #4817 which fixed an intermittent failure of the test
backup.backup_innodbon Microsoft Windows.