Skip to content

MDEV-39861 innodb_log_recovery_target wrongly opens log in read-write mode#5185

Merged
dr-m merged 1 commit into
13.0from
MDEV-39861
Jun 5, 2026
Merged

MDEV-39861 innodb_log_recovery_target wrongly opens log in read-write mode#5185
dr-m merged 1 commit into
13.0from
MDEV-39861

Conversation

@dr-m

@dr-m dr-m commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

log_t::archived_switch_recovery_prepare(): Observe recv_sys.rpo similar to what recv_sys_t::find_checkpoint() does.

This is based on b98be03 from #4817 which fixed an intermittent failure of the test backup.backup_innodb on Microsoft Windows.

@dr-m dr-m requested a review from Thirunarayanan June 5, 2026 12:03
@dr-m dr-m self-assigned this Jun 5, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the file creation logic in log0recv.cc by removing the int{} cast from i->second.access and adding recv_sys.rpo as an alternative condition. The reviewer points out that removing the cast could lead to compilation issues if access is a strongly-typed enum, and suggests comparing it directly to READ_ONLY for improved readability and type safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread storage/innobase/log/log0recv.cc Outdated
… mode

log_t::archived_switch_recovery_prepare(): Observe recv_sys.rpo
similar to what recv_sys_t::find_checkpoint() does.
@dr-m dr-m merged commit 3a19b9a into 13.0 Jun 5, 2026
17 of 19 checks passed
@dr-m dr-m deleted the MDEV-39861 branch June 5, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants