platform-checks: fix silently ignored flags, replica masking, state leaks#37519
Open
def- wants to merge 1 commit into
Open
platform-checks: fix silently ignored flags, replica masking, state leaks#37519def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
…eaks * Plumb --system-param and --default-replication-factor through to the Mz instances started by StartMz. Both flags were silently ignored because StartMz overrides the service definition wholesale. Also parse all values of a multi-value --system-param instead of only the first. * UseClusterdCompute: drop all quickstart replicas, not just r1. Since the default replication factor is 2, the orchestrated r2 kept serving queries and masked compute restarts in RestartClusterdCompute and the UpgradeClusterdCompute* scenarios. * cloudtest: sort checks before sharding so that parallel jobs agree on the shard split. Set iteration order differs between processes, so checks could run twice or not at all. * Wipe the environment between scenario runs (and between checks in oneatatime mode), iterate scenarios in deterministic order, use a fresh executor per run, and copy the check list before shuffling. Previously state leaked from one run into the next. * Make Executor.system_settings per instance and record settings as applied only after the testdrive applying them has succeeded. * Backup scenarios: restart Mz through StartMz instead of Restore(restart_mz=True) so the restored instance keeps the service definition it was started with (e.g. the SASL listener). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test runs: https://buildkite.com/materialize/nightly/builds/17084 & https://buildkite.com/materialize/release-qualification/builds/1303