data-ingest: Fix data generation and executor issues#37520
Draft
def- wants to merge 1 commit into
Draft
Conversation
- Text.random_value: the special-values branch (NULL, unicode, numbers as strings) was dead code, always overwritten by the record-size branch - Insert: restart keys on each generate() call so cycling workloads (DeleteDataAtEndOfDay*) insert again after the first cycle instead of degenerating into no-op deletes - DeleteDataAtEndOfDay*: the delete phase now actually runs as a single transaction, as its comment claims - Upsert: honor the keyspace parameter, reject the unimplemented EXISTING - Replace the type blocklists with explicit allowlists and drop types from DATA_TYPES_FOR_MYSQL that cannot work: MzTimestamp and TimestampTz have no MySQL type, Timestamp and Date values exceed MySQL's ranges - Seed the row-value rng so --seed makes runs fully reproducible - Sort WORKLOADS so rng.choice in parallel-workload is deterministic - PrintExecutor: don't connect to Mz, --verbose crashed when the randomly picked materialized2 wasn't up yet - Executor.execute: only retry OperationalErrors against Mz, never redirect an upstream Postgres query to the Mz connection Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run: https://buildkite.com/materialize/nightly/builds/17085