mzcompose: Fix various issues#37521
Merged
Merged
Conversation
- invoke: non-str stdin (e.g. subprocess.DEVNULL) was silently dropped because isinstance against typing.IO is always False - test_parts: don't let test-analytics failures mask the real test result, and catch cloud_hostname's timeout UIError in create_test_analytics_config so the fallback hostname works - sql-server: healthcheck's ONLINE guard needs sqlcmd -b to actually fail, without it the check is a plain connectivity probe - balancerd: fix misspelled --frontegg-resolver-template flag - run: -d/--detach take no value; -u/--user, --env, --env-from-file, --pull, --cap-add and --cap-drop do - --sanitizer: keep Enum members as shtab-compatible choices, name strings never match the type-converted member so every value was rejected - sql: make the postgres-metadata branch reachable, it was shadowed by the materialize/postgres branch and connected to 5432 instead of 26257 - test_result: include stdout in error details (testdrive prints errors to stdout), drop the pre-error output chunk, and fix an off-by-one when the error report starts at position 0 - Materialized/Testdrive/Debezium/SqlLogicTest: stop mutating caller-provided (often shared) parameter dicts and env/entrypoint lists - remove or honor accepted-but-ignored parameters: Environmentd and Orchestratord resolver templates, Dnsmasq command, TestCerts name, MaterializeEmulator image Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run: https://buildkite.com/materialize/nightly/builds/17088