Skip to content

mzcompose: Fix various issues#37521

Merged
def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-mzcompose-improve
Jul 9, 2026
Merged

mzcompose: Fix various issues#37521
def- merged 1 commit into
MaterializeInc:mainfrom
def-:pr-mzcompose-improve

Conversation

@def-

@def- def- commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
  • invoke: non-str stdin (e.g. subprocess.DEVNULL) was silently dropped because isinstance against typing.IO is always False
  • test_parts: don't let test-analytics failures mask the real test result, and catch cloud_hostname's timeout UIError in create_test_analytics_config so the fallback hostname works
  • sql-server: healthcheck's ONLINE guard needs sqlcmd -b to actually fail, without it the check is a plain connectivity probe
  • balancerd: fix misspelled --frontegg-resolver-template flag
  • run: -d/--detach take no value; -u/--user, --env, --env-from-file, --pull, --cap-add and --cap-drop do
  • --sanitizer: keep Enum members as shtab-compatible choices, name strings never match the type-converted member so every value was rejected
  • sql: make the postgres-metadata branch reachable, it was shadowed by the materialize/postgres branch and connected to 5432 instead of 26257
  • test_result: include stdout in error details (testdrive prints errors to stdout), drop the pre-error output chunk, and fix an off-by-one when the error report starts at position 0
  • Materialized/Testdrive/Debezium/SqlLogicTest: stop mutating caller-provided (often shared) parameter dicts and env/entrypoint lists
  • remove or honor accepted-but-ignored parameters: Environmentd and Orchestratord resolver templates, Dnsmasq command, TestCerts name, MaterializeEmulator image

Test run: https://buildkite.com/materialize/nightly/builds/17088

- invoke: non-str stdin (e.g. subprocess.DEVNULL) was silently dropped
  because isinstance against typing.IO is always False
- test_parts: don't let test-analytics failures mask the real test
  result, and catch cloud_hostname's timeout UIError in
  create_test_analytics_config so the fallback hostname works
- sql-server: healthcheck's ONLINE guard needs sqlcmd -b to actually
  fail, without it the check is a plain connectivity probe
- balancerd: fix misspelled --frontegg-resolver-template flag
- run: -d/--detach take no value; -u/--user, --env, --env-from-file,
  --pull, --cap-add and --cap-drop do
- --sanitizer: keep Enum members as shtab-compatible choices, name
  strings never match the type-converted member so every value was
  rejected
- sql: make the postgres-metadata branch reachable, it was shadowed by
  the materialize/postgres branch and connected to 5432 instead of 26257
- test_result: include stdout in error details (testdrive prints errors
  to stdout), drop the pre-error output chunk, and fix an off-by-one
  when the error report starts at position 0
- Materialized/Testdrive/Debezium/SqlLogicTest: stop mutating
  caller-provided (often shared) parameter dicts and env/entrypoint
  lists
- remove or honor accepted-but-ignored parameters: Environmentd and
  Orchestratord resolver templates, Dnsmasq command, TestCerts name,
  MaterializeEmulator image

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@def- def- requested review from antiguru and bosconi July 9, 2026 07:53
@def- def- marked this pull request as ready for review July 9, 2026 07:53
@def- def- changed the title mzcompose: Fix various bugs mzcompose: Fix various issues Jul 9, 2026

@antiguru antiguru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@def- def- merged commit 6d7c9ab into MaterializeInc:main Jul 9, 2026
357 of 360 checks passed
@def- def- deleted the pr-mzcompose-improve branch July 9, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants