makeboxes eval_infix should use always the internal utf encoding. - #1892
Merged
Conversation
rocky
reviewed
Aug 15, 2026
| if self._elements is None: | ||
| # self.box_options | ||
| self._elements = elements_to_expressions( | ||
| self, |
Member
There was a problem hiding this comment.
Pyrefly is showing a number of type errors around this section of code. But that can be addressed some other time.
rocky
reviewed
Aug 15, 2026
|
|
||
| @property | ||
| def is_multiline(self) -> bool: | ||
| return self.boxes.is_multiline |
Member
There was a problem hiding this comment.
I think self.boxes should be self.inner_box now.
But again, this is not central to this PR; just something noticed.
Member
|
LGTM. I'm glad we are starting to address some of the many boxing issues we have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeBoxes should produce strings that do not depend on
$SystemCharacterEncoding. The encoding must be taken into account just at the rendering step (when converting the Box expression into a string or LaTeX output). This PR fixes the remaining place where this pattern was not followed and produced errors when callpytest /test/format/test_format.pywith "ASCII" as the system encoding. With this adjustment, tests pass regardless of the system character encoding.