docs(merge-queue): clarify stacks override scope/file similarity in batching#11702
Merged
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
This PR clarifies how merge-queue batching works in serial mode by explicitly separating the similarity ranking (priority/scopes/directories/queue time) from the stack-co-location constraint, so readers don’t misinterpret stacks as an additional “fifth tier” that comes after file similarity.
Changes:
- Updates the parallel-mode reference to point to Queue Modes → Parallel Mode instead of the stale
/merge-queue/parallel-scopeslink. - Adds explicit wording that the similarity ranking applies only to independent PRs, and that stack dependencies are handled by a separate rule that overrides similarity.
- Rewrites the “Stacks stay together” section to state that predecessors are pulled into the same batch regardless of scope/directory overlap, bounded by
batch_size.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jd
reviewed
Jun 2, 2026
…atching The batch-grouping section listed priority, scopes, changed directories, and queue time as the similarity ranking, then described stacks in a separate paragraph that read as a fifth tier of that order. Readers (jd on PR #11693) took it as "scope -> files -> stack" and expected stack to come before files. Reframe the stack rule to match the engine: in serial mode stack co-location is a separate constraint outside the similarity ranking (_add_pull_with_predecessors), not a ranking tier. Selected pull requests drag their queued predecessors into the same batch regardless of scope or directory overlap, so stack relationships take precedence over scope and directory similarity, bounded only by batch_size. Also repoint the stale parallel-scopes link to queue-modes#parallel-mode. Fixes MRGFY-7466 Change-Id: I8a0172f86b0629e0086e51c038e0244339086447
f765079 to
ec8ee0c
Compare
Member
Author
Revision history
|
jd
approved these changes
Jun 2, 2026
JulianMaurin
approved these changes
Jun 2, 2026
Contributor
Merge Queue Status
This pull request spent 2 minutes 17 seconds in the queue, including 1 minute 50 seconds running CI. Required conditions to merge
|
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch-grouping section listed priority, scopes, changed directories,
and queue time as the similarity ranking, then described stacks in a
separate paragraph that read as a fifth tier of that order. Readers
(jd on PR #11693) took it as "scope -> files -> stack" and expected
stack to come before files.
Reframe the stack rule to match the engine: in serial mode stack
co-location is a separate constraint outside the similarity ranking
(_add_pull_with_predecessors), not a ranking tier. Selected pull
requests drag their queued predecessors into the same batch regardless
of scope or directory overlap, so stack relationships take precedence
over scope and directory similarity, bounded only by batch_size.
Also repoint the stale parallel-scopes link to queue-modes#parallel-mode.
Fixes MRGFY-7466