Skip to content

Add e2e coverage for the open-house API: no end-to-end spec exercises scheduling and RSVP #1080

Description

@nanaf6203-bit

Add e2e coverage for the open-house API: no end-to-end spec exercises scheduling and RSVP

Labels / Complexity: testing · Medium Complexity — Medium

Problem

The test/e2e/ suite has no spec for the open-house module (6 files, 0 unit specs). Open-house scheduling and RSVP involve property owners and attendees, and none of it is pinned at the HTTP level. A regression that lets attendees RSVP to cancelled events or owners lose control of their listings ships silently.

Why this is architecturally hard

  1. Ownership boundaries are the test design. The spec must assert that only the property owner can schedule/modify, and attendees can RSVP — the RBAC e2e pattern applied to a resource-ownership model.
  2. State transitions need fixtures. Schedule → RSVP → cancel flows need seeded properties and users.

Acceptance criteria

  • An e2e spec covers scheduling, RSVP, and cancellation with correct ownership/attendee access.
  • The spec runs in CI with the existing e2e harness.

Out of scope

Unit coverage (#30); open-house behavior changes.

Getting started

  • src/open-house/open-house.controller.ts — the endpoints
  • test/e2e/rbac-enforcement.e2e.spec.ts — the access-boundary pattern

Commands: npm run test:e2e (or the repo's e2e script from package.json).

Good first files to read: test/e2e/rbac-enforcement.e2e.spec.ts, src/open-house/open-house.controller.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions