Repository navigation
Resolve copied Bazel products from the execution root - #3358
Open
karim-alweheshy wants to merge 2 commits into
Open
karim-alweheshy wants to merge 2 commits into
karim-alweheshy wants to merge 2 commits into
Conversation
Use PROJECT_DIR for relative product paths and retain the full binary product name. Reject missing products instead of copying a stale SRCROOT output. Cover ordinary and legacy builds with distinct source and execution roots. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
marked this pull request as ready for review
October 7, 2026 18:38
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
added a commit
that referenced
this pull request
Oct 8, 2026
Signed-off-by: Karim Alweheshy <9082720+karim-alweheshy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve generated Bazel product paths from the selected execution root (
PROJECT_DIR), notSRCROOT, and reject missing or dangling product sources before copying. Add shell integration coverage for distinct project/source roots and product variants.Validation
The diff adds shell integration coverage for distinct project/source roots and product variants. Tests were not rerun for this description update.
Testing
Run
bazel test //test/internal/bazel_integration_files:preview_framework_scripts, including missing and dangling source cases. This is staging-path coverage, not proof of a Preview Canvas render.