feat(engine): add transient in-memory graphs - #500
Open
mrkorchun wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Embedded runtimes need the normal typed graph operations without filesystem hard-link requirements or a durable graph directory. This gives them the same schema, mutation, query, manifest, and branch machinery as durable graphs while keeping lifecycle explicitly process-local.
Validation
Known ceiling
Lance retains shared-memory authorities for the process lifetime. Explicit reclamation is deferred until long-lived embedded hosts demonstrate that it is needed.
Greptile Summary
The PR adds isolated, process-local in-memory graphs while preserving the existing graph initialization, manifest, mutation, query, and branch machinery.
Omnigraph::in_memory(schema_source)using Lance’s native shared-memory URI scheme.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains; the public API registry now classifies the constructor, and the owning user documentation describes its transient and non-reopenable lifecycle.
Important Files Changed
in_memoryas a bootstrap write surface, resolving the previously reported registry failure.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Caller[Embedded Rust caller] --> Constructor[Omnigraph::in_memory] Constructor --> URI[Private shared-memory URI] Constructor --> Init[Shared graph initialization path] Init --> Metadata[In-memory schema and recovery metadata] Init --> Lance[Lance shared-memory datasets] Lance --> Operations[Typed mutation, query, manifest, and branch operations] Operations --> Exit[State discarded at process exit]Reviews (3): Last reviewed commit: "docs(storage): document transient graphs" | Re-trigger Greptile
Context used: