Check Apollo models with additional CoCos#152
Draft
linggd wants to merge 2 commits into
Draft
Conversation
linggd
changed the title
| if(!name.matches("^(?!0-9)[a-zA-Z0-9_]+$") && !name.isEmpty()) { | ||
| // Names must start with a letter or underscore. | ||
| // Subsequent characters may also include digits, spaces, dots, and hyphens. | ||
| // Names like 'Roger B. Chaffee' , 'F-1', 'SA-500F' can be accepted. |
Contributor
There was a problem hiding this comment.
Siehe auch https://git.rwth-aachen.de/monticore/languages/sysml2/sysml2official/-/work_items/52
Ich denke die korrekte Lösung ein Encoding der Namen im Transformer ist. Vorschlag:
<ASCII letters/digits> --> identisch
_ (Underscore) --> __ (double Underscore)
Unicode U+XXXX --> _uXXXX_
Dieser PR kann nicht gemerged werden, bitte mit anderen CoCos weitermachen.
Danach hier: https://git.rwth-aachen.de/montibelle/frontend/transformer/sysmltransformer/-/work_items/320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apollo-11 models can already be parsed(#146) . The symbol resolution and CoCos are adapted so that the models also pass the CoCos.
1/5 errors exposed by the CoCos:
0xFF005 — adapted : Valid quoted SysML names containing spaces, dots, or hyphens, such as 'Roger B. Chaffee', were previously rejected by the Isabelle name validation and caused this error. The validation was extended to accept these names.
Changelog
Changed