fix CoCo error 0x10AA1 - imported and quoted PartDef resolution#153
Open
linggd wants to merge 3 commits into
Open
fix CoCo error 0x10AA1 - imported and quoted PartDef resolution#153linggd wants to merge 3 commits into
linggd wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apollo-11 models can already be parsed #146 . The symbol resolution and CoCos are adapted so that the models also pass the CoCos.
2 of 5 CoCo errors addressed
0x10AA1— PartDef resolutionApollo introduced several cases that were not covered by the previous models:
:typing and:>specialization. The CoCo incorrectly checked both as PartDefs.,resolveType(), but not forresolvePartDef().,'Roger B. Chaffee'. The dots were incorrectly interpreted as qualification separators.,These cases exposed missing or incorrect behavior in the PartDef resolution.
Changelog
Fix