Skip to content

doc: add rttov sensor file namelist item for rttov13 - #1202

Open
hkershaw-brown wants to merge 3 commits into
mainfrom
rttov13-nml
Open

hkershaw-brown wants to merge 3 commits into
mainfrom
rttov13-nml

Conversation

@hkershaw-brown

Copy link
Copy Markdown
Collaborator

Description:

Please provide a summary of the change and include any relevant motivation and context.

  • Add rttov sensor file namelist item for rttov13 in the obs_def_mod_rttov documentation
  • Changed the doc on "default" file for rttov12- not the default in the namelist ("unspecified"), the file provided by dart
    'rttov_sensor_db.csv'
  • Also coefficient was missing an 'i' in multiple places this page so I fixed the spelling.

Fixes issue

Fixes #1197

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Spellcheck of coefficient: https://nwp-saf.eumetsat.int/site/software/rttov/download/coefficients/coefficient-download/
Built documentation locally

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

.. code-block:: text

&obs_def_rttov_nml
rttov_sensor_db_file = 'unspecified' ! Set to rttov_sensor_db.csv, example provided in DART/observations/forward_operators/rttov_sensor_db.csv

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be 'unspecified'. I think it would be better to have the this be 'rttov_sensor_db.csv' like it is in the docs for the 12 version.

Then overall, I think it would be better to actually change the default value in obs_def_rttov_mod.f90 and obs_def_rttov13_mod.f90 from 'unspecified' to 'rttov_sensor_db.csv'. We could then maybe have a more helpful error message in subroutine read_sensor_db_file

character(len=512) :: rttov_sensor_db_file = 'unspecified'

subroutine read_sensor_db_file(sensor_db_file)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with this. Let's loop in Brett on the rttov default filename option before changing the code.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes all seem reasonable to me.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great @braczka I'll go ahead and make the code changes.

note on "default" file - not the default in the namelist, the file
provided by dart

fixes #1197
@hkershaw-brown hkershaw-brown added the release! bundle with next release label Nov 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release! bundle with next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: rttov 13 obs_def mod needs rttov_sensor_db_file namelist item in v13 nml

3 participants