CCM-16933: regression test framework#189
Conversation
rhyscoxnhs
force-pushed
the
feature/CCM-16933-regression-test-framework
branch
from
1deb8ae to
1093ab1
Compare
| purgeQueue(sqsClient, failingDeliveryQueueUrl), | ||
| purgeQueue(sqsClient, failingDlqUrl), | ||
| purgeQueue(sqsClient, healthyDeliveryQueueUrl), | ||
| purgeQueue(sqsClient, healthyDlqUrl), |
There was a problem hiding this comment.
If these tests involve the circuit breaker we'll need to purge valkey also. We already do this in the integration tests so you may be able to copy the implementation from there.
There was a problem hiding this comment.
I'll check this out and implement if needed.
|
|
||
| for (const failingMsg of failingMessages) { | ||
| const failingMsgId = failingMsg.payload.data[0].attributes.messageId; | ||
| const webhookLogs = await queryLogEntries( |
There was a problem hiding this comment.
We have some cloudwatch query helpers in the integration tests already. If they're not already in a shared module we could refactor them out into one so both test suites can use them
| messageStatus?: string; | ||
| }; | ||
|
|
||
| export function createDeliveryMessage( |
There was a problem hiding this comment.
We have some event factory helpers in the integration tests already. If they're not already in a shared module we could refactor them out into one so both test suites can use them
There was a problem hiding this comment.
I think Copilot followed the same pattern as the integration tests ones but yes, it would be good to make it so that we have a shared one. Unless we think there is a reason why we want to keep the regression and integration tests completely separate? 🤔
| ); | ||
|
|
||
| for (const event of response.events ?? []) { | ||
| if (event.message) { |
There was a problem hiding this comment.
This might look a little cleaner if we bail out early, e.g.:
if (!event.message) {
continue;
}Alternatively you could do this in a chained style:
(response.events ?? []).filter(event => !!event.message).forEach(event => {
try {
...
});There was a problem hiding this comment.
I'll refactor this to one of these options 👍
CCM-16933: fixed AWS access issues CCm-16933: tests running CCM-16933: update gitignore CCM-16933: phase2 test framework setup CCM-16933: refactor CCM-16933 - Resolved merge conflicts CCM-16933 - Restored packages removed from rebase CCM-16933: all tests passing
rhyscoxnhs
force-pushed
the
feature/CCM-16933-regression-test-framework
branch
from
79b8252 to
8d1742d
Compare
2 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.