Skip to content

Allow project-specific validation in omm update - #60

Merged
johnnygreco merged 2 commits into
mainfrom
johnny/omm-update-check-command
Sep 10, 2026
Merged

Allow project-specific validation in omm update#60
johnnygreco merged 2 commits into
mainfrom
johnny/omm-update-check-command

Conversation

@johnnygreco

Copy link
Copy Markdown
Collaborator

Summary

Allow existing Python middleware projects to use their normal validation command during omm update, instead of the default pytest invocation:

omm update /path/to/middleware --openshell-version v0.0.116 --check-command 'make check'
  • Run the command in the staged project and isolated Python environment after binding generation and dependency sync, before publishing generated artifacts.
  • Parse quoted arguments without invoking a shell; keep the existing default validation and file-publication safeguards unchanged.
  • Cover argument parsing, staged execution, and validation failure with regression tests, and document usage.

This is the manager-only work split out from the Pi admission example in #38. It contains no Pi harness changes, Egress Gate changes, generated protocol changes, or dependency additions. The example's pending generation-script update depends on this option and should follow this PR.

Validation

  • uv run --frozen ruff format --check .
  • uv run --frozen ruff check .
  • uv run --frozen ty check
  • uv run --frozen pytest — 91 passed; 95.83% coverage
  • uv build
  • python3 tests/test_render_dev_notes.py — 11 passed
  • scripts/build-docs.sh — strict build and artifact checks passed

Known limitation

The README also records an existing starter-template incompatibility with OpenShell v0.0.116 (max_body_bytes). This PR does not change starter templates or claim to fix omm create for that release; it enables validation of updates to services already compatible with that contract.

@johnnygreco
johnnygreco merged commit 9d041c3 into main Sep 10, 2026
15 checks passed
@johnnygreco
johnnygreco deleted the johnny/omm-update-check-command branch September 10, 2026 19:19
johnnygreco added a commit that referenced this pull request Sep 10, 2026
Delegate generation to omm with project validation and publish its generated bindings and manifest. Align project guidance with the issue-first policy for manager gaps.

The generation helper depends on the --check-command option in PR #60.
johnnygreco added a commit that referenced this pull request Sep 11, 2026
Delegate generation to omm with project validation and publish its generated bindings and manifest. Align project guidance with the issue-first policy for manager gaps.

The generation helper depends on the --check-command option in PR #60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant