Add theme-aware OAR logo to README and documentation - #71
Merged
Conversation
Documentation previewThe preview has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the NVIDIA-green OAR logo to the project README header and documentation landing page. The logo is a transparent SVG with an oar integrated into the A and a terminal prompt cutout in its blade.
Lettering adapts to light and dark mode. Documentation styling follows the site's theme toggle, including when it differs from the operating system's theme. The canonical asset lives in
projects/openshell-agent-runner/assets/and is copied into the documentation by the staging script. The README uses a relative image URL so it renders on the PR branch as well as main. The source distribution includes the asset. Asset-only changes also trigger documentation previews.Validation:
make check: 153 tests passed, plus formatting, lint, type, compilation, and shell checks.make build: source distribution and wheel built successfully.python3 tests/test_render_dev_notes.pyandscripts/build-docs.sh: passed.