Skip to content

fix(build): honor Cargo target directory when staging binaries #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimlock merged 1 commit into from
Sep 10, 2026
Merged

fix(build): honor Cargo target directory when staging binaries #3262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tasks/scripts/stage-prebuilt-binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ build_component_for_arch() {
local current_host_os
local current_host_arch
local binary_path
local cargo_output_dir
local build_rustflags

resolve_component "$component"
Expand Down Expand Up @@ -257,7 +258,8 @@ build_component_for_arch() {
CARGO_INCREMENTAL=0 mise x -- ${cargo_env[@]+"${cargo_env[@]}"} "${cargo_subcommand[@]}" "${args[@]}"
)

binary_path="${ROOT}/target/${target}/release/${binary}"
cargo_output_dir="$(cd "$ROOT" && mise x -- cargo metadata --format-version=1 --no-deps | jq -er '.target_directory')"
binary_path="${cargo_output_dir}/${target}/release/${binary}"
if [[ "$component" == "gateway" ]]; then
"$SCRIPT_DIR/verify-glibc-symbols.sh" 2.28 "$binary_path"
elif [[ "$component" == "supervisor" ]]; then
Expand Down
Loading