fix(ci): restore Windows test portability - #3288
Merged
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 11, 2026 18:13
Collaborator
Author
|
/ok to test b775f59 |
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Collaborator
Author
|
/ok to test fc74d79 |
krishicks
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore portability of two tests that broke the advisory Windows MSVC checks on
main, and make Unix-specific pre-commit tasks behave correctly under native Windows.The regressions were introduced by:
#[cfg(unix)]and the FIFO test, leaving thenix-dependent FIFO test enabled on Windows.Related Issue
No issue required: this is an obvious localized correction to two test regressions and their native-Windows validation path.
Changes
nix::unistd::mkfifo.buf.cmdshim forproto:lint.Testing
mise run pre-commitcompletes on native Windowsmise run windows:test:x64(3,540 passed, 16 skipped)Checklist