Skip to content

fix(ci): restore Windows test portability - #3288

Merged
pimlock merged 3 commits into
mainfrom
windows-ci-regressions/pm
Sep 11, 2026
Merged

fix(ci): restore Windows test portability#3288
pimlock merged 3 commits into
mainfrom
windows-ci-regressions/pm

Conversation

@pimlock

@pimlock pimlock commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Restore portability of two tests that broke the advisory Windows MSVC checks on main, and make Unix-specific pre-commit tasks behave correctly under native Windows.

The regressions were introduced by:

Related Issue

No issue required: this is an obvious localized correction to two test regressions and their native-Windows validation path.

Changes

  • Expect the OCSF device OS name to match the build platform.
  • Restore the Unix-only guard on the FIFO test that uses nix::unistd::mkfifo.
  • Explicitly skip the Unix shell-based Cargo lockfile check on native Windows.
  • Use npm's Windows buf.cmd shim for proto:lint.

Testing

  • mise run pre-commit completes on native Windows
  • mise run windows:test:x64 (3,540 passed, 16 skipped)
  • Native Windows Rust lint, including the e2e and example manifests
  • E2E tests added/updated (not applicable; test and task portability fixes)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pimlock pimlock added the test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors label Sep 11, 2026
@pimlock

pimlock commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test b775f59

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@pimlock

pimlock commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test fc74d79

@pimlock
pimlock added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 5b57f0d Sep 11, 2026
64 checks passed
@pimlock
pimlock deleted the windows-ci-regressions/pm branch September 11, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:windows Run native Windows x64 and ARM64 lint/tests on PR mirrors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants