Repository navigation
fix(ocsf): move sandbox container to device.container - #5017
Open
ericcurtin wants to merge 2 commits into
Open
ericcurtin wants to merge 2 commits into
ericcurtin wants to merge 2 commits into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@krishicks PTAL, and |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@krishicks Merged main. The validator moved to |
8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the sandbox identity from top-level
containertodevice.container, which OCSF 1.8.0 defines.Related Issue
Closes #4915
Changes
device.containerinstead of a top-levelcontainer.container.image, since OCSF requires an image ID we do not have.device.containeron downgrade to 1.1 and 1.3.container.Release Notes
Sandbox ID and name move from
containertodevice.containerin OCSF records. Update parsers that readcontainer.uidorcontainer.name.Testing
All 10 builder samples return 0 errors from
schema.ocsf.io/api/1.8.0/v2/validate. The e2e assertion is updated but not run.Checklist