Repository navigation
fix(build): restore Windows lint and trim the image build context - #5021
Merged
krishicks merged 2 commits intoOct 28, 2026
Merged
Conversation
The Windows-only host proxy passed 18 arguments to ProxyHandle::start_with_bind_addr after #4276 added reserved_destination. It hosts no OTLP relay, so it passes None. The network supervisor trust artifact helpers only act on Unix, so Clippy flags their Result as unnecessary on Windows; allow it there, as other cfg-dependent helpers do. Signed-off-by: Kris Hicks <khicks@nvidia.com>
.dockerignore excluded only the top-level target directory, so image builds from the repository root also sent nested Cargo target directories (e2e/rust, tests, examples), node_modules, and the .jj store as context: about 15 GB in a local checkout, which a remote Podman machine copies on every build. Exclude target and node_modules at any depth, and .jj. The images copy only prebuilt binaries from deploy/docker/.build. Signed-off-by: Kris Hicks <khicks@nvidia.com>
TaylorMutch
approved these changes
Oct 28, 2026
krishicks
deleted the
fix/build-windows-lint-and-docker-context/krishicks
branch
October 28, 2026 23:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two build problems on
main: the Windows MSVC lint lanes fail, and local image builds send about 15 GB of nested build output as context.Related Issue
Build fix; no issue (see
CONTRIBUTING.md). The Windows lanes fail onmainwiththis function takes 19 arguments but 18 arguments were suppliedinopenshell-supervisor-network/src/host.rsand Clippyunnecessary_wrapsinopenshell-server/src/network_trust.rs.Changes
Nonefor thereserved_destinationargument that feat(supervisor): relay agent OTLP traces to the collector #4276 added toProxyHandle::start_with_bind_addr; it hosts no OTLP relay.clippy::unnecessary_wrapson other platforms, as other cfg-dependent helpers do..dockerignoreexcluded only the top-leveltarget, so builds from the repository root also sent nested Cargotargetdirectories (e2e/rust,tests/*,examples/*),node_modules, and the.jjstore. It now excludes**/target,**/node_modules, and.jj. The images copy only prebuilt binaries fromdeploy/docker/.build, ande2e/mcp-conformancehas its own ignore file.Testing
openshell-serverbuilds on macOS; the Windows lanes on this PR verify the Windows fix, which needs an MSVC hostChecklist