style: apply ruff 0.15.2 formatting to drifted files (unblocks CI format check)#207
Conversation
Four files were committed under an older ruff and no longer match `ruff format` under the pinned ruff 0.15.2 (uv.lock), so the CI `ruff format --check src/ tests/` job fails on main and on every PR branch regardless of its content. Reformat them to restore a clean check. No behaviour change: ruff format only adjusts whitespace and literal layout (for example, expanding a hand-condensed frozenset literal one element per line). Files: src/skillspector/nodes/analyzers/static_runner.py, tests/nodes/analyzers/test_binary_and_pe3_filtering.py, tests/nodes/analyzers/test_mp2_regex_backtracking.py, tests/nodes/test_llm_analyzer_base.py. Signed-off-by: Werner Kasselman <145896621+wernerkasselman-au@users.noreply.github.com>
rng1995
left a comment
There was a problem hiding this comment.
Approving — formatting-only (ruff 0.15.2). I diffed the content: _BINARY_EXTENSIONS membership is unchanged (only reflowed one-per-line), and the signature/log/test reflows carry no logic changes. Unblocks the CI format check.
|
@wernerkasselman-au fix the CI issue |
|
Closing as obsolete. The ruff 0.15.2 formatting this PR applied is already present on This branch is based on an older No action needed; the formatting goal is achieved on |
What this fixes
The CI
ruff format --check src/ tests/job is currently failing onmain, not on any one PR. Four files were committed under an older ruff and no longer matchruff formatunder the version this repo now pins (ruff>=0.15.0inpyproject.toml, whichuv.lockresolves to0.15.2), so the format job reports them as needing reformatting and exits non-zero. Because that check runs over the whole tree, every open PR inherits the red job regardless of what it changes. I hit it while getting CI green on two unrelated fixes (#204, #205), and it traces back tomainitself.The change
uv run ruff format src/ tests/, nothing more. It touches exactly the four drifted files and leaves the other 120 untouched:src/skillspector/nodes/analyzers/static_runner.py(a hand-condensedfrozenset({...})literal that 0.15.2 expands one element per line)tests/nodes/analyzers/test_binary_and_pe3_filtering.pytests/nodes/analyzers/test_mp2_regex_backtracking.pytests/nodes/test_llm_analyzer_base.pyNo behaviour change:
ruff formatonly adjusts whitespace and literal layout. I kept it to formatting on purpose so it is a safe, reviewable catch-up rather than mixing in anything else.Verification
If you would rather pin ruff to an exact version (so a future ruff bump does not re-introduce this drift on a
>=floor), I am happy to follow up with that separately; this PR just restores the clean check against the version already in the lock.