[None][doc] Add trtllm-bench LWS launch guidance - #17235
Conversation
Signed-off-by: zq <zhouquan1511@163.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe performance benchmarking guide adds instructions for multi-node PyTorch throughput benchmarks using ChangesMulti-node benchmarking
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/developer-guide/perf-benchmarking.md`:
- Around line 311-313: Update the gpus_per_node guidance in the benchmarking
documentation to describe it as a per-node override: instruct users to pass it
only when the runtime-inferred value from local MPI ranks and visible GPUs
differs from the actual GPUs available per Pod, not when Pod GPUs are fewer than
the total world size.
- Line 255: Add an NVIDIA copyright header with the current year at the
beginning of the Markdown file, before the existing developer-guide content and
heading.
- Around line 303-310: Update the parallel-world invariant in the benchmarking
guide so cp_size=1 requires --tp * --pp to equal the LLM world size, while other
configurations use tp_size * pp_size * cp_size; correct the --tp 8 --pp 2
example to use -np 16 when cp_size=1. Add the NVIDIA copyright header with the
current year at the document’s header.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2701101a-1c36-4e1b-a50b-d0bf4ba6a5a4
📒 Files selected for processing (1)
docs/source/developer-guide/perf-benchmarking.md
Signed-off-by: zq <zhouquan1511@163.com>
Summary
trtllm-benchguidance for Kubernetes LeaderWorkerSet-style deployments.trtllm-llmapi-launchrank-per-GPU launch contract, using the existing Slurm MGMN script as the canonical reference.gpus_per_nodevia--configbecause it is not exposed as a throughput CLI flag.Test Plan
git diff --checkpython -m sphinx --versionfails locally withNo module named sphinx)Refs #15104
Dev Engineer Review
trtllm-benchexecution in Kubernetes LeaderWorkerSet deployments.trtllm-llmapi-launchrank-per-GPU launch contract.gpus_per_nodemust be set through--config.git diff --check.QA Engineer Review
No test changes.