[None][chore] Remove the disagg transfer admission controller - #17245
Closed
Tabrizian wants to merge 1 commit into
Closed
[None][chore] Remove the disagg transfer admission controller#17245Tabrizian wants to merge 1 commit into
Tabrizian wants to merge 1 commit into
Conversation
Remove the FCFS admission gate for disaggregated generation KV transfers from the PyTorch executor, along with the plumbing that existed only to serve it: - `DisaggTransferAdmissionController` / `DisaggTransferAdmissionResult` - `_get_disagg_transfer_admission_controller`, `_apply_disagg_transfer_admission` - `_revert_deferred_disagg_gen_init_alloc`, `_uses_kv_manager_v2`, `_revert_ctx_alloc` - The `wait_for_disagg_gen_transfer_progress` flag threaded through `SerializableSchedulerOutput` and the PP schedule broadcast, and the generation-side branch of `_check_disagg_transfer_progress_when_idle` it gated (`_sync_disagg_gen_status_entry`) The `max_tokens_in_buffer` / `kv_transfer_poll_interval_ms` cache transceiver config fields and the C++ `DisaggTransferAdmissionController` used by the TensorRT backend are left untouched. Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
Member
Author
|
/bot run --disable-fail-fast |
Tabrizian
deleted the
user/itabrizian/remove-disagg-transfer-admission-controller
branch
August 4, 2026 07:26
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesDisaggregated transfer admission removal
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: ✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the FCFS admission gate for disaggregated generation KV transfers from
the PyTorch executor (
DisaggTransferAdmissionController), introduced inb6eacd1 (
[TRTLLM-12721][fix] Bound V2 context transfer polling, #15356).Removed along with it, because each became dead once the gate was gone:
DisaggTransferAdmissionController/DisaggTransferAdmissionResult_get_disagg_transfer_admission_controller,_apply_disagg_transfer_admission_revert_deferred_disagg_gen_init_alloc,_uses_kv_manager_v2— only evercalled to undo KV growth for gate-deferred requests
_revert_ctx_alloc— no remaining callerswait_for_disagg_gen_transfer_progressflag threaded throughSerializableSchedulerOutputand the PP schedule broadcast. With the gategone it is permanently
False, which made the generation-side branch of_check_disagg_transfer_progress_when_idle(and its_sync_disagg_gen_status_entryallreduce) unreachable, so both are removed.One behavioral note beyond dead-code deletion: in the PP loop, non-rank-0 ranks
still run
scheduler.schedule_request(...)for its request-state side effects,but no longer reconcile their local disagg candidates against rank 0's admitted
set. That reconciliation only had an effect when the gate deferred requests, so
it is a no-op now.
Deliberately left untouched:
DisaggTransferAdmissionController(
cpp/include/tensorrt_llm/batch_manager/disaggTransferAdmissionController.hand its
trtGptModelInflightBatchingwiring) used by the TensorRT backend.max_tokens_in_buffer/kv_transfer_poll_interval_msfields onCacheTransceiverConfig, so this PR carries no public API change.Test Coverage
This PR only removes code, so coverage is the existing suites minus the tests
for the removed paths:
tests/unittest/_torch/executor/test_py_executor.py— removedTestDisaggTransferAdmissionController(8 tests) andTestDisaggTransferAdmissionPP(2 tests). InTestDisaggTransferIdleProgress,the two tests covering the generation-side branch are removed; the two
context-side tests are kept and updated for the new signature, so the
remaining idle-progress behavior stays covered.
tests/unittest/_torch/executor/test_scheduler_serializable_output.py—SerializableSchedulerOutputpickle round-trip still covered, minus theremoved flag.
(
tests/integration/defs/accuracy/test_disaggregated_serving.py) exercise theend-to-end path this code sat on.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit
Bug Fixes
Refactor
Tests