Skip to content

[None][chore] Fix guardword - #17250

Merged
nvpohanh merged 1 commit into
NVIDIA:mainfrom
tongyuantongyu:ytong/fix-guardword
Aug 5, 2026
Merged

[None][chore] Fix guardword#17250
nvpohanh merged 1 commit into
NVIDIA:mainfrom
tongyuantongyu:ytong/fix-guardword

Conversation

@tongyuantongyu

@tongyuantongyu tongyuantongyu commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Guard word check does not like developer name in the codebase.

Test Coverage

Trivial comment modification.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

  • Updated the TODO comment in get_base_page_indices.
  • Removed the author attribution that triggered the guard word check.
  • Preserved the planned nanobind API migration note.
  • No functional code, API, performance, error handling, or configuration changes.
  • The comment-only change is consistent with the stated objective.

QA Engineer Review

No test changes.

Signed-off-by: Yuan Tong <13075180+tongyuantongyu@users.noreply.github.com>
@tongyuantongyu
tongyuantongyu requested a review from lowsfer August 4, 2026 09:43
@tongyuantongyu
tongyuantongyu marked this pull request as ready for review August 4, 2026 09:43
@tongyuantongyu
tongyuantongyu requested a review from a team as a code owner August 4, 2026 09:43
@tongyuantongyu
tongyuantongyu requested review from nvpohanh and removed request for nvpohanh August 4, 2026 09:43
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The pull request removes author attribution from a TODO comment in get_base_page_indices. The nb::memview migration note remains unchanged.

Changes

Nanobind comment update

Layer / File(s) Summary
Update migration TODO
cpp/tensorrt_llm/nanobind/batch_manager/kvCacheManagerV2.cpp
The TODO comment removes the yaoy attribution and retains the nb::memview migration note.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: lowsfer

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the guardword fix and uses the required ticket and type format.
Description check ✅ Passed The description explains the issue, identifies the comment-only solution, documents test coverage, and includes the completed checklist.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tongyuantongyu

Copy link
Copy Markdown
Member Author

/bot skip --comment "Comment changes only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63736 [ skip ] triggered by Bot. Commit: 827132b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63736 [ skip ] completed with state SUCCESS. Commit: 827132b
Skipping testing for commit 827132b

Link to invocation

@nvpohanh
nvpohanh merged commit 9cb1a92 into NVIDIA:main Aug 5, 2026
14 of 16 checks passed
@tongyuantongyu
tongyuantongyu deleted the ytong/fix-guardword branch August 5, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants